Remove unused elements from user me fees #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unpaidFeesText & prePaymentTypeChangeDateText & postPaymentTypeChangeDateText become unpaidFeesFirstHeadlineText & unpaidFeesSecondHeadlineText
Most of TotalPaymentPay isn't used anymore in the project, and the rest is but a couple divs, so I removed the component and moved the leftover HTML into the parent component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-332
Description
This PR removes a sizeable chunk of the bottom part of the fees list. As a result, I deleted a single component and moved its leftovers to the parent component (only a couple of lines of HTML). Connected Cypress tests were also removed, and two new translatable strings were added. as the list headlines are supposed to be two different translations.
Screenshot of the result
Additional comments or questions
n/a