Fix group loan modal #754
Merged
Fix group loan modal #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobArrow
reviewed
Dec 6, 2023
Comment on lines
37
to
+41
| if (openDueDateModal && dueDate) { | ||
| openDueDateModal(dueDate); | ||
| return; | ||
| } | ||
| openLoanDetailsModal(loan); |
There was a problem hiding this comment.
This feels weird somehow
Why not just a regular if/else or just
(openDueDateModal && dueDate) ? openDueDateModal(dueDate) : openLoanDetailsModal(loan)
There was a problem hiding this comment.
Correct, but you can either return the whole statement or remove the curly braces
const handleOpenDueDateModal = () =>
openDueDateModal && dueDate
? openDueDateModal(dueDate)
: openDueDateModal(dueDate);
OR
const handleOpenDueDateModal = () => {
return openDueDateModal && dueDate
? openDueDateModal(dueDate)
: openDueDateModal(dueDate);
};
JacobArrow
previously approved these changes
Dec 6, 2023
When clicking on the title, two modals would open - one event triggered by clicking the title on the card, and the other triggered by the card itself.
DDF would like to be able to define what stands before the actual number
It is not possible to pay through our solution. Thus we are removing all of these payment instances.
Instead of the date when the material was returned to the library.
Adamik10
changed the title
JacobArrow
reviewed
Dec 27, 2023
src/apps/loan-list/materials/stackable-material/material-info.tsx
Outdated
Show resolved
Hide resolved
In order not to repeat the same twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-295
Description
A couple of elements are removed from the group modal for loan fees.
Screenshot of the result
AFTER:
BEFORE:
Additional comments or questions
n/a