Update interest period treshold with drupal #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have never been configured for availability labels on the work and search result page.
Refer to this PR for the JSON data structure: danskernesdigitalebibliotek/dpl-cms#475
This affected the UserListItems component, NoInterestAfterModal, and the helper in the reservation directory.
Dresse
reviewed
Dec 11, 2023
JacobArrow
reviewed
Dec 12, 2023
JacobArrow
reviewed
Dec 12, 2023
JacobArrow
reviewed
Dec 12, 2023
JacobArrow
reviewed
Dec 12, 2023
JacobArrow
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
I'm gonna approve this, but I really think you should rethink the implementation of the interestPeriods object. It seems like don't really need the whole object anywhere and are using either defaultInterestPeriod or interestPeriods, and are therefore making unnecessary property accessors.
I know its a minor thing, but interestPeriod.interestPeriods.find() is just not very pretty.
If you just want this out in a hurry, then doing something like this, will be the quick (but not perfect) solution: periods.interestPeriods.find()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-150
Description
This PR updates the usage of the "interest period" after which a loaner is no longer interested in a material when reserving it. There were some updates in the backend to the structure of the data we use, so here we update the frontend part.
We also add new wiremock stubs for the material page (so that it doesn't crash when running it locally).
Screenshot of the result
n/a
Additional comments or questions
n/a