Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/translation error throwing #828

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Jan 2, 2024

Link to issue

Description

Errors were being thrown left and right for translations defined as empty strings. That shouldn't be the case.

Screenshot of the result

n/a

Additional comments or questions

n/a

@Adamik10 Adamik10 requested a review from spaceo January 2, 2024 14:00
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Adamik10 Adamik10 merged commit a0c7fa7 into release/2024-1-0 Jan 2, 2024
16 checks passed
@Adamik10 Adamik10 deleted the fix/translation-error-throwing branch January 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants