Release/2024 1 0 #840
Merged
Release/2024 1 0 #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking on the title, two modals would open - one event triggered by clicking the title on the card, and the other triggered by the card itself.
…e-fees Show fees after payment change date on the fees page
…remove-placeholder Removed placeholder for mobile input
A div is not semantically correct to use inside a h-tag. Instead we should use a span and tell the screen reader to percieve it as a text.
…p-into-release-2024-1-0 Merge develop into release/2024-1-0
DDF would like to be able to define what stands before the actual number
It is not possible to pay through our solution. Thus we are removing all of these payment instances.
Instead of the date when the material was returned to the library.
E.g. the counter.
To be consistent all places, we use this default interest period. Plus default interest period on the patron isn't adjustable anywhere in the project.
We were experiencing problems with default values in dropdowns, because when comparing two values, although they were same, they were not of the same type (string/number), which cause buggy behavior.
In order not to repeat the same twice.
…an-modal Fix group loan modal
The FBI API came out with some changes to their specs, so we now need to update how we contact it. As a part of this, most keys of advancedSearchIndexTranslations also needed to be updated to match.
Because it wasn't a boolean before, number 0 was showing on the page as a part of the loading results text headline.
In order for the arrow in the card to get animated.
Because it containes an arrow button inside.
In that way we can change FBI graphql url depending on which query that is being executed. We need that because DDF wants to change profile name depending on which query that is being run.
…-1-0_with-develop Release/2024 1 0 with develop
…s-group-card-click Fix single vs group loan click events
…ced-search-filters Update advanced search filters
Because it is either one or the other.
The work is not finished and breaks the application as it is right now.
…entally-added-fbi-base-url-changes Removing accidentally added work-in-progress fbi url changes
…header-semantics Use correct semantics for header
…ion-error-throwing Fix/translation error throwing
..DescriptionText.
Missing - feeDetailsModalCloseModalAriaLabelText & feeDetailsModalDescriptionText
…translations-again Add missing translations again
…-period Fix/interest period
to 0.0.0-53111dc1d5d35ee254a8e231f1e3721088240a4a
Instead of the whole autosuggest. For some reason Cypress says it can't see the whole thing so it's not visible apparently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.