Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revoke endpoint #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update revoke endpoint #4

wants to merge 1 commit into from

Conversation

kasperg
Copy link
Collaborator

@kasperg kasperg commented Aug 12, 2019

According to Adgangdplatformen developers the correct endpoint for revoking tokens is not what is says in the documentation.

Update this accordingly.

According to Adgangdplatformen developers the correct endpoint for revoking tokens is not what is says in the documentation.

Update this accordingly.
@codecov-io
Copy link

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage     90.66%   90.66%           
  Complexity       41       41           
=========================================
  Files             9        9           
  Lines           150      150           
=========================================
  Hits            136      136           
  Misses           14       14
Impacted Files Coverage Δ Complexity Δ
src/Provider/Adgangsplatformen.php 86.66% <100%> (ø) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4c393...df916f7. Read the comment docs.

@kasperg
Copy link
Collaborator Author

kasperg commented Aug 12, 2019

A suggestion for updated documentation is here: DBCDK/hejmdal#570.

@kasperg kasperg requested a review from xendk August 12, 2019 14:38
Copy link
Contributor

@xendk xendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kasperg
Copy link
Collaborator Author

kasperg commented Aug 13, 2019

@xendk: Having a command to generate a working token is actually useful as you need it to test reload/material-list with actual data. This command is one approach to get such a token. With this command added the token will no longer be valid.

I see a few options here:

  1. Remove revoking from TokenCommand entirely
  2. Add an argument to the TokenCommand to tell whether the token should be revoked or not
  3. Implement a separate command to revoke a token

Thoughts?

@xendk
Copy link
Contributor

xendk commented Aug 13, 2019

@kasperg
3 and a prettier UI than print_r() (perhaps with a -d switch for print_r()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants