-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alacritty: Use TOML template for recent versions #219
Conversation
Since version 0.13.0 alacritty has switched to TOML config file format. For backwards compatibility this patch implements conditional template format depending on the package version. Closes #214
This change is quite straightforward. I've tested it locally with alacritty from 23.11 and unstable channels. Here are excerpts from the logs for pre-0.13.0 and 0.13.1:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I like the backwards compatibility :)
To reduce maintainence cost should we only support the latest package version, similar to how Home Manager does it:
|
That was my initial thought, but that would make it impossible for stylix to be used against 23.11 atm. |
Does the Line 3 in a9e3ce0
|
Well, even if stylix uses unstable for it's own instance of nixpkgs that does not mean it's unreasonable for the user to use the latest stable. In that case stylix should produce valid configs. The optimal solution is to just take a resonable commit and fork a stable branch that should be used in such cases. I think my original point is kind of moot right now since there's a 23.11 branch, so this should be addressed there. Feel free to remove this W/A on master |
Anyway, I've found an instance in home-manager where the exact thing happened to zellij: c03d1e75a1e5e10384e2836cdd6537a4e94be89a. So on the second thought maybe this is fine as is |
Perhaps we should have a general policy written down somewhere for which versions need to be backwards compatible. |
Since version 0.13.0 alacritty has switched to TOML config file format. For backwards compatibility this patch implements conditional template format depending on the package version.
Closes #214