k9s: Fix deprecation warning #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move style into variable Renames style to stylix in new module
Lillecarl
changed the title
Lillecarl
changed the title
mrcjkb
added a commit
to mrcjkb/nixfiles
that referenced
this pull request
Jan 22, 2024
|
Looks okay to me. For some reason, k9s isn't picking up the skin for me, although the configs seem to be generated and symlinked in the right places. I'll have to look into that another time... |
Just noticed the following warning while rebuilding:
Maybe that's why? Update: This should be fixed once #232 is merged. |
mrcjkb
approved these changes
Jan 28, 2024
|
Yep, #232 would fix it. If we're only targeting home-manager master it's the better solution :) |
|
#232 is merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move style into variable
Renames style to stylix in new module
This is untested inside k9s, sadly I don't have access to any k8s clusters right now, the deprecation warning was just annoying me.
@mrcjkb @dwarfmaster
Here's stylix.yaml and skins/stylix.yaml with this module https://gist.github.com/Lillecarl/b2cd18eac6cf35f24834f695196fd375