Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tofi: init #355

Merged
merged 2 commits into from
May 9, 2024
Merged

tofi: init #355

merged 2 commits into from
May 9, 2024

Conversation

aftix
Copy link
Contributor

@aftix aftix commented May 1, 2024

Added stylix target for tofi, a wayland dmenu alternative.

Based off the existing rofi target.

@aftix
Copy link
Contributor Author

aftix commented May 1, 2024

Locally, the failed CI tests are working for me. The tofi HM module is only two weeks old, could the stylix flake input for it be older than that?

@trueNAHO
Copy link
Collaborator

trueNAHO commented May 2, 2024

Locally, the failed CI tests are working for me.

All tests are failing for this reason:

Run nix -L build github:danth/stylix/5d6eadb3edcd8bcb64090fa27a1527eeeb87d738#packages.x86_64-darwin.docs
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:9:12:
            8|
            9|   strict = derivationStrict drvAttrs;
             |            ^
           10|

       … while evaluating derivation 'stylix-book'
         whose name attribute is located at /nix/store/fszphhr0kc59brk510m3a579vjbjdy2s-source/pkgs/stdenv/generic/make-derivation.nix:331:7

       … while evaluating attribute 'patchPhase' of derivation 'stylix-book'
         at /nix/store/ljy1ym11j0rrnc3s3if80darc5gi1msn-source/docs/default.nix:44:3:
           43|
           44|   patchPhase = ''
             |   ^
           45|     cp ${../README.md} src/README.md

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: The option `programs.tofi' does not exist. Definition values:
       - In `/nix/store/whm360hyl2wcjbj5kal4wxibpb1hnr5q-modules/tofi/hm.nix':
           {
             _type = "if";
             condition = true;
             content = {
               settings = {
           ...

The tofi HM module is only two weeks old, could the stylix flake input for it be older than that?

You can compare your minimum Home Manager revision requirement with the one in flake.lock:

stylix/flake.lock

Lines 166 to 185 in 2f29ecd

"home-manager": {
"inputs": {
"nixpkgs": [
"nixpkgs"
]
},
"locked": {
"lastModified": 1711915616,
"narHash": "sha256-co6LoFA+j6BZEeJNSR8nZ4oOort5qYPskjrDHBaJgmo=",
"owner": "nix-community",
"repo": "home-manager",
"rev": "820be197ccf3adaad9a8856ef255c13b6cc561a6",
"type": "github"
},
"original": {
"owner": "nix-community",
"repo": "home-manager",
"type": "github"
}
},

However, based on the error, it seems like the Home Manager input is too old. In that case, update the Home Manager input in this PR.

@trueNAHO trueNAHO changed the title Added stylix target for tofi, a wayland dmenu alternative tofi: init May 2, 2024
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using config.lib.stylix.colors.withHashtag.

@aftix aftix force-pushed the master branch 3 times, most recently from 9d37947 to 4e5efa0 Compare May 2, 2024 23:27
@aftix
Copy link
Contributor Author

aftix commented May 2, 2024

I've changed to withHashtagand removed an unnecessary string interpolation

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but LGTM.

@aftix
Copy link
Contributor Author

aftix commented May 6, 2024

It was being used as the background, i've updated from base00 -> base02

@danth
Copy link
Owner

danth commented May 6, 2024

Apologies, I meant selection (which is still base03), not background. base00 is correct as a general background color.

@aftix
Copy link
Contributor Author

aftix commented May 6, 2024

selection is the foreground, currently the selection background is set to the same as the default background (base00). The selection is base03

@danth
Copy link
Owner

danth commented May 9, 2024

In that case, I think it's fine. We don't really have an agreed color for selection foregrounds right now.

@danth danth merged commit f1bb5c5 into danth:master May 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants