Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cava: init with rainbow theme #638

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Conversation

brckd
Copy link
Contributor

@brckd brckd commented Nov 18, 2024

This PR inits the cava target which doesn't apply any changes by default yet. However, it adds a stylix.targets.cava.rainbow.enable option for a rainbow gradient, which is often used with this application.

Before After
Screenshot From 2024-11-18 19-59-09 Screenshot From 2024-11-18 20-01-57

I'm not sure how and whether to handle gradients with stylix, but I used the colors for images from the style guide and sorted them rainbow-ishly. If there are more applications using gradients like this, it would make sense to add a stylix wide option to define the preferred gradient or solid color.

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how and whether to handle gradients with stylix, but I used the colors for images from the style guide and sorted them rainbow-ishly. If there are more applications using gradients like this, it would make sense to add a stylix wide option to define the preferred gradient or solid color.

IIRC, this is the first module with explicit gradient support.

@brckd
Copy link
Contributor Author

brckd commented Nov 19, 2024

I currently can't test this because of NixOS/nixpkgs#356817, but the suggested solution should work!

@trueNAHO
Copy link
Collaborator

fix in unstable now, no issue for me anymore

-- NixOS/nixpkgs#356817 (comment)

brckd and others added 2 commits December 19, 2024 13:57
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
@brckd brckd force-pushed the cava/init-rainbow branch from be64ab3 to 903062d Compare December 19, 2024 13:00
@brckd
Copy link
Contributor Author

brckd commented Dec 19, 2024

I was able to confirm that your suggested change works!

@brckd brckd requested a review from trueNAHO December 19, 2024 13:02
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
@brckd brckd force-pushed the cava/init-rainbow branch from d46a9ad to 39d4a59 Compare December 21, 2024 23:33
@brckd
Copy link
Contributor Author

brckd commented Dec 21, 2024

Thanks for the suggestions! I've successfully tested the changes after replacing the faulty references to cava with cfg.

@trueNAHO trueNAHO enabled auto-merge (squash) December 22, 2024 16:08
@trueNAHO trueNAHO merged commit be3a33d into danth:master Dec 22, 2024
12 checks passed
stylix-automation bot pushed a commit that referenced this pull request Jan 4, 2025
Link: #638

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit be3a33d)
@stylix-automation
Copy link

Successfully created backport PR for release-24.11:

trueNAHO pushed a commit that referenced this pull request Jan 4, 2025
Link: #638

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit be3a33d)
@cluther cluther mentioned this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants