-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cava: init with rainbow theme #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how and whether to handle gradients with stylix, but I used the colors for images from the style guide and sorted them rainbow-ishly. If there are more applications using gradients like this, it would make sense to add a stylix wide option to define the preferred gradient or solid color.
IIRC, this is the first module with explicit gradient support.
I currently can't test this because of NixOS/nixpkgs#356817, but the suggested solution should work! |
|
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
be64ab3
to
903062d
Compare
I was able to confirm that your suggested change works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
d46a9ad
to
39d4a59
Compare
Thanks for the suggestions! I've successfully tested the changes after replacing the faulty references to |
Successfully created backport PR for |
This PR inits the
cava
target which doesn't apply any changes by default yet. However, it adds astylix.targets.cava.rainbow.enable
option for a rainbow gradient, which is often used with this application.I'm not sure how and whether to handle gradients with stylix, but I used the colors for images from the style guide and sorted them rainbow-ishly. If there are more applications using gradients like this, it would make sense to add a stylix wide option to define the preferred gradient or solid color.