Mvp kotlin

[daolq-2712]

Related Tickets

• #Task xxxxx: Content

WHAT

Evidence (Screenshot or Video)

Review Checklist

Category	View Point	Description	Expected Reviewer Answer	Self review	Reviewer2 (name)
Conventions	Does the code follow Sun* coding style and coding conventions?	https://github.com/framgia/coding-standards/blob/master/eng/android/coding_convention_android_kotlin.md	YES	yes	yes
Redmine	Does the ticket follow Sun* Redmine working process?	https://github.com/framgia/Training-Guideline/blob/master/WorkingProcess/redmine/redmine.md	YES	yes	yes
Documentation	Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’?		YES	yes	yes

Notes (Optional)

(Impacted Areas in Application(List features, api, models or services that this PR will affect))

(Other notes)

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
4266195	Generic High Entropy Secret	767a2fa	gradle.properties	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>