Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16640 vos: tune aggregation credits for phase2 pool #15735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NiuYawei
Copy link
Contributor

When md-on-ssd phase2 pool runs into space pressure, larger SCAN credits will be used to reduce yield & reprobe on iterating, larger DEL credits will be used to drop more punched objects to GC in one batch, so that GC will likely reclaim more objects when reclaiming a bucket.

Though larger aggregation credits will lower front end I/O performance, it can greatly reduce page misses for GC when free space/page is tight.

This PR also fixed the NE space pressure check, where the sys reserved space should not be taken into account.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

When md-on-ssd phase2 pool runs into space pressure, larger SCAN credits
will be used to reduce yield & reprobe on iterating, larger DEL credits
will be used to drop more punched objects to GC in one batch, so that GC
will likely reclaim more objects when reclaiming a bucket.

Though larger aggregation credits will lower front end I/O performance,
it can greatly reduce page misses for GC when free space/page is tight.

This PR also fixed the NE space pressure check, where the sys reserved
space should not be taken into account.

Signed-off-by: Niu Yawei <[email protected]>
@NiuYawei NiuYawei requested review from a team as code owners January 15, 2025 07:47
Copy link

Ticket title is 'Space pressure checking for phase2 pool'
Status is 'Reopened'
Labels: 'md_on_ssd2'
https://daosio.atlassian.net/browse/DAOS-16640

Copy link
Contributor

@wangshilong wangshilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have performance numbers with/without PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants