Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16958 CI: increase timeout for Unit Test with memcheck #15739

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wiliamhuang
Copy link
Contributor

@wiliamhuang wiliamhuang commented Jan 16, 2025

Increase timeout to avoid issues on slow CI nodes with broadwell.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wiliamhuang wiliamhuang requested a review from a team as a code owner January 16, 2025 19:41
Copy link

github-actions bot commented Jan 16, 2025

Ticket title is 'To increase timout for step "Unit Test with memcheck on EL 8.8" in Jenkins'
Status is 'In Review'
Errors are Component should be lower-case
https://daosio.atlassian.net/browse/DAOS-16958

Signed-off-by: Lei Huang <[email protected]>
Copy link
Contributor

@mchaarawi mchaarawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add the hpe copyright :-)
the change is fine for me. it is concerning though that our test VMs are that different. at some point we should talk with DCO team to remove the old VMs from commission.

@daltonbohning
Copy link
Contributor

I wonder if this is related to https://daosio.atlassian.net/browse/SRE-471, which we've never gotten a resolution for

Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on copyright

@wiliamhuang
Copy link
Contributor Author

you need to add the hpe copyright :-) the change is fine for me. it is concerning though that our test VMs are that different. at some point we should talk with DCO team to remove the old VMs from commission.

"Copyright 2025 Hewlett Packard Enterprise Development LP" was already added to this file last week.

@daltonbohning
Copy link
Contributor

you need to add the hpe copyright :-) the change is fine for me. it is concerning though that our test VMs are that different. at some point we should talk with DCO team to remove the old VMs from commission.

"Copyright 2025 Hewlett Packard Enterprise Development LP" was already added to this file last week.

Ah, it's because you committed with an intel email instead of hpe

@wiliamhuang
Copy link
Contributor Author

Ah, it's because you committed with an intel email instead of hpe

Thank you! I will start using HPE email in next PR.

@wiliamhuang wiliamhuang requested a review from a team January 17, 2025 14:58
Copy link
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title needs to follow format

@wiliamhuang wiliamhuang changed the title increase timeout for Unit Test with memcheck DAOS-16958 CI: increase timeout for Unit Test with memcheck Jan 17, 2025
@wiliamhuang wiliamhuang requested a review from a team January 17, 2025 15:46
@wiliamhuang
Copy link
Contributor Author

Commit message title needs to follow format

Just updated the title. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants