Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking if proposed release is desired with semver #392

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Checking if proposed release is desired with semver #392

merged 1 commit into from
Feb 21, 2024

Conversation

mateumiralles
Copy link
Contributor

Instead of checking with regex if proposed release has "-rc" or "nightly" on its version, checking it with semver lib

@mateumiralles mateumiralles requested a review from a team as a code owner February 20, 2024 17:11
@pablomendezroyo pablomendezroyo merged commit e29816b into dappnode:master Feb 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablomendezroyo pablomendezroyo pablomendezroyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateumiralles @pablomendezroyo