Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update core packages versions #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 6, 2024

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot requested a review from a team as a code owner November 6, 2024 15:55
@@ -23,7 +23,7 @@
"dependencies": {
"bind.dnp.dappnode.eth": "0.2.11",
"ipfs.dnp.dappnode.eth": "0.2.23",
"dappmanager.dnp.dappnode.eth": "0.2.93",
"dappmanager.dnp.dappnode.eth": "0.2.95",
"wifi.dnp.dappnode.eth": "0.2.9"
},
"optionalDependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im confused, in no situation is a VPN client NOT installed. Wireguard is a mandatory package, VPN is optional and any install in the last 2 years or so, its not included. WiFi is more optional than a VPN client.

But the biggest thing is that HTTPS is not ANYWHERE in core deps or in core optional deps. Its causing problems and im getting it uninstalled or not updated randomly.

Copy link
Contributor

@pablomendezroyo pablomendezroyo Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im confused, in no situation is a VPN client NOT installed. Wireguard is a mandatory package, VPN is optional and any install in the last 2 years or so, its not included

The core packges to be installed are determined here https://github.com/dappnode/DAppNode/blob/d01ecfc2c51d4bbb7337097f8bd622b7d615ff60/scripts/dappnode_install.sh#L65
Installing dappnode should always come with a pre-installed vpn package (either openvpn or wireguard).

WiFi is more optional than a VPN client.

Wifi is a must in physical dappnodes. Generally, Its a better plugNplay solution

But the biggest thing is that HTTPS is not ANYWHERE in core deps or in core optional deps. Its causing problems and im getting it uninstalled or not updated randomly.

HTTPS is not a mandatory core package but optional. Also, optional deps means "if installed in dappnode, they will be updated to defined version". Check out https://github.com/dappnode/DNP_DAPPMANAGER/blob/904843640972cf669b4b4e5e22829d0d81799a19/packages/schemas/src/schemas/manifest.schema.json#L201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants