-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(postgres): add iam roles anywhere auth profile #3604
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 0e4401c |
Components conformance testCommit ref: 0e4401c ❌ Some conformance tests failedThese tests failed:
|
Components certification testCommit ref: 0e4401c ❌ Some certification tests failedThese tests failed:
|
func (a *StaticAuth) getDatabaseToken(ctx context.Context, poolConfig *pgxpool.Config) (string, error) { | ||
dbEndpoint := poolConfig.ConnConfig.Host + ":" + strconv.Itoa(int(poolConfig.ConnConfig.Port)) | ||
switch { | ||
case a.accessKey != nil && a.secretKey != nil: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than this I would do a simple if statement, much simpler to read
so this PR is missing the assume role auth profile, right? |
Pls give me a sec on this PR bc I do need to make tweaks, but doing the kafka PR first. |
Description
Add IAM Roles Anywhere auth profile to PostgreSQL components.
I saw where we've had fields like
awsAccessKey
andawsSecretKey
fields specific to postgres. However, in the AWS built in profiles for authentication we haveaccessKey
andsecretKey
. I've moved things to where we have some TODO comments to remove those aws prefixed fields in Dapr 1.17; however, to not break existing users, we cannot just remove these additional fields. Due to this, I had to manually manipulate the metadata bundle even further unfortunately. This is something we should never do. However, again in the case of the auth profile titled"AWS: Access Key ID and Secret Access Key"
I am forced to update the manipulations further to make the normally requiredaccessKey
andsecretKey
fields as non-required as we make a transition in the next two releases to the normalized AWS auth profile fields without theaws
prefix.AWS Auth profiles with these changes:
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: