Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When leveraging Kafka Pubsub Avro serialization, caching should be enabled by default with a TTL of 5min #3610

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

When leveraging Kafka Pubsub Avro serialization, caching should be enabled by default with a TTL of 5min #3610

wants to merge 2 commits into from
+21 −0

Conversation

passuied
Copy link
Contributor

@passuied passuied commented Nov 22, 2024 •
edited
Loading

Description

  • When leveraging Kafka Pubsub Avro serialization, caching should be enabled by default with a TTL of 5min
  • Also, addresses another issue where poison pill messages could be skipped in some weird circumstances after a context cancelation, which doesn't in turn seem to come from session.Context()
    • To keep things simple and avoid playing 'whack 'em all', always exit the for loop in case the NotifyRecover fails...
    • Let dapr re-initiate the session in those cases

Issue reference

#3609
#3529

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@passuied
When leveraging Kafka Pubsub Avro serialization, caching should be en…
6917a79 
…abled by default with a TTL of 5min

Signed-off-by: Patrick Assuied <[email protected]>
@passuied passuied requested review from a team as code owners November 22, 2024 05:14
@passuied
- Address another issue where poison pill messages could be skipped i…
4c769a2 
…n some weird circumstances

  - To avoid complexity, always exiting the for loop in case the RetryNotify fails...
  - Let dapr re-initiate the session in those cases
- Address PR feedback and fix breaking tests

Signed-off-by: Patrick Assuied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevgen-el8 yevgen-el8 Awaiting requested review from yevgen-el8

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@passuied @yevgen-el8