Skip to content

Commit

Permalink
Updating PR based on updated implementation in dapr/dapr
Browse files Browse the repository at this point in the history
Signed-off-by: Chris Gillum <[email protected]>
  • Loading branch information
cgillum committed Oct 30, 2023
1 parent 87613e7 commit 3c074e9
Showing 1 changed file with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -192,19 +192,19 @@ The `workflow` section under the `Configuration` spec contains the following pro

```yml
workflow:
maxConcurrentWorkflows: 100
maxConcurrentActivities: 100
maxConcurrentWorkflowInvocations: 100
maxConcurrentActivityInvocations: 100
```

The following table lists the properties for workflow:

| Property | Type | Description |
|--------------|--------|-------------|
| `maxConcurrentWorkflows` | integer | The maximum number of concurrent workflow functions that can be invoked concurrently at any given time per sidecar. Default: `100`. |
| `maxConcurrentActivities` | integer | The maximum number of concurrent activity functions that can be invoked concurrently at any given time per sidecar. Default: `100`. |
| `maxConcurrentWorkflowInvocations` | integer | The maximum number of concurrent workflow functions that can be invoked concurrently at any given time per sidecar. Default: `100`. |
| `maxConcurrentActivityInvocations` | integer | The maximum number of concurrent activity functions that can be invoked concurrently at any given time per sidecar. Default: `100`. |

{{% alert title="Note" color="primary" %}}
The `maxConcurrentWorkflows` and `maxConcurrentActivities` properties are used to control concurrent function invocation. They do not control the number of workflow instances that can be created, nor do they limit the number of workflow instances that can be in a running state at any given time. They also cannot be used to limit specific workflow or activity functions. Rather, these settings are primarily intended for controlling overall thread and CPU usage in workflow applications. See [Workflow architecture]({{< ref "workflow-architecture.md" >}}) for more information about workflow execution.
The `maxConcurrentWorkflowInvocations` and `maxConcurrentActivityInvocations` properties are primarily intended for controlling overall thread and CPU usage in workflow applications by limiting the amount of workflow code that runs on a given replica at any given point in time. Any workflow or activity invocations scheduled beyond these limits will be blocked until the current number of concurrent invocations decreases below the configured limits. See [Workflow architecture]({{< ref "workflow-architecture.md" >}}) for more information about workflow execution.
{{% /alert %}}

#### Scope secret store access
Expand Down Expand Up @@ -292,8 +292,8 @@ spec:
httpVerb: ["*"]
action: allow
workflow:
maxConcurrentWorkflows: 100
maxConcurrentActivities: 100
maxConcurrentWorkflowInvocations: 100
maxConcurrentActivityInvocations: 100
```

## Control plane configuration
Expand Down

0 comments on commit 3c074e9

Please sign in to comment.