Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagram deck #3768

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Update diagram deck #3768

merged 7 commits into from
Oct 6, 2023

Conversation

hhunter-ms
Copy link
Collaborator

Update diagram deck with images added for 1.11

Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms requested a review from a team as a code owner September 26, 2023 14:31
@hhunter-ms hhunter-ms self-assigned this Sep 26, 2023
@hhunter-ms hhunter-ms requested a review from a team as a code owner September 26, 2023 14:31
@msfussell
Copy link
Member

Here are my suggestions

  1. Can we update Icons slide to include workflow icon
  2. remove slides 8-11. (Keeping on slide 12 in this set)
  3. Remove 13 (keep 14)
  4. Remove 22 and 23 (Keep 24)
  5. Remove 40

Also this looks like it is not the latest deck. This image is missing https://docs.dapr.io/developing-applications/building-blocks/workflow/workflow-patterns/#fan-outfan-in

I have an image for Outbox pattern to add.

@hhunter-ms
Copy link
Collaborator Author

Also this looks like it is not the latest deck. This image is missing https://docs.dapr.io/developing-applications/building-blocks/workflow/workflow-patterns/#fan-outfan-in

Fan out/fan in diagram isn't in the latest deck - just confirmed this after downloading the latest from the site. who created that slide? I don't have it.

I have an image for Outbox pattern to add.

This PR is pointing to 1.11 - should the outbox pattern be added to a 1.12 PR?

@msfussell
Copy link
Member

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 7fece60 into dapr:v1.11 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants