Fix Subscription docs to match Kubernetes CRDs #3888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Updates https://docs.dapr.io/reference/resource-specs/subscription-schema/ to match CRDs properties from https://github.com/dapr/dapr/blob/release-1.12/charts/dapr/crds/subscription.yaml.
Changes some properties from the current docs which are wrong and prevents Subscriptions resources to be created from this docs.
Maybe hardest to catch is
match
is not optional as per -> https://github.com/dapr/dapr/blob/release-1.12/charts/dapr/crds/subscription.yaml#L134-L135Issue reference
I do not have a reported issues and this change is small enough to not need it.