[AWS SSM parameter store] Add prefix option #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
|
@berndverst - Can you check this PR for correctness also? |
|
@ostreek could you review as well? |
|
Stale PR, paging all reviewers |
|
Sorry for the slow reply Hannah, I didn't get a notification. Thanks for picking this up. What you've written is correct, I agree with this change. The docs for the Azure key vault secret store are very good, they give an example of how to create a key vault and configure the component to use it. It'd be great if we could provide similar instructions here, to show how to use the prefix option and explain how it maps to the parameter store. But I suggest you merge this PR now and maybe we can further improve the page later. Thanks again for documenting this, I'm sorry I didn't do this at the time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2763