Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(kafka): add recent kafka enhancements #4099

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

sicoyle
Copy link
Contributor

@sicoyle sicoyle commented Apr 4, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add new kafka metadata fields with some recent PRs getting merged.
dapr/components-contrib#3375
dapr/components-contrib#3371

Issue reference

@sicoyle sicoyle requested review from a team as code owners April 4, 2024 20:54
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 10, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 7a386ba into dapr:v1.14 Apr 12, 2024
4 checks passed
@dapr dapr deleted a comment from holopin-bot bot Apr 12, 2024
@sicoyle sicoyle deleted the feat-kafka-enhancements branch April 18, 2024 13:49
@marcduiker
Copy link
Contributor

@holopin-bot @sicoyle Thanks Sam! 😁

Copy link

holopin-bot bot commented Apr 24, 2024

Congratulations @sicoyle, you just earned a badge! Here it is: https://holopin.io/claim/clvdu5dy0128500flalvjsyh4f

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants