Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

high priority class name recommendation #4178

Merged
merged 24 commits into from
Jun 19, 2024
Merged

high priority class name recommendation #4178

merged 24 commits into from
Jun 19, 2024

Conversation

filintod
Copy link
Contributor

@filintod filintod commented Jun 1, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Following PR for critical priority class resourcequota that needs to be merged first dapr/dapr#7784

Issue reference

To Add after dapr/dapr#7784

@filintod filintod requested review from a team as code owners June 1, 2024 21:49
@filintod filintod changed the base branch from v1.13 to v1.14 June 1, 2024 21:49
@filintod filintod force-pushed the filinto/high-priority-class-name branch from bf0bf34 to f2bc026 Compare June 3, 2024 13:16
@hhunter-ms hhunter-ms added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Jun 3, 2024
hhunter-ms
hhunter-ms requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review

filintod and others added 11 commits June 3, 2024 15:44
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
9ca676c 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
07ab2ed 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
0189cd4 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
5fc9388 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
1505c3a 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
81b3135 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
8fa6902 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
2d67252 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
c5e920b 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
d626c44 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @hhunter-ms
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
56de990 
…roduction.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod filintod requested a review from hhunter-ms June 5, 2024 02:48
msfussell
msfussell reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filintod - Please review my feedback/comments

daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
For a new Dapr deployment, this priority class can be set with both the Dapr CLI and Helm charts,
using the helm `--set global.priorityClassName=system-cluster-critical` argument.

#### Dapr version < 1.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question. Why version 1.14 and below? What is different from 1.14 onwards, is this set for you by default? It does not say.

Copy link
Contributor Author

@filintod filintod Jun 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 1.14 chart now adds this automatically for the user.

filintod and others added 3 commits June 17, 2024 15:50
@filintod @msfussell
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
167e5f7 
…roduction.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @msfussell
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
a9ac8be 
…roduction.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@filintod @msfussell
Update daprdocs/content/en/operations/hosting/kubernetes/kubernetes-p…
4ce666f 
…roduction.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
@hhunter-ms hhunter-ms removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Jun 19, 2024
msfussell
msfussell approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit cfbef2c into dapr:v1.14 Jun 19, 2024
6 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @filintod Thanks Filinto!

@holopin-bot Holopin Bot
Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @filintod, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8qxyb45450cjvgq2zt07q

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@hhunter-ms hhunter-ms hhunter-ms approved these changes

Assignees

@filintod filintod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filintod @marcduiker @msfussell @hhunter-ms