Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder TOC and update diagrams to match #4184

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Conversation

hhunter-ms
Copy link
Collaborator

Description

Rearrange TOC for APIs/building blocks in order of popularity
Update relevant diagrams

Issue reference

PR will close: #4183

Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms self-assigned this Jun 4, 2024
@hhunter-ms hhunter-ms requested review from a team as code owners June 4, 2024 15:23
@msfussell
Copy link
Member

msfussell commented Jun 8, 2024

The icons for Azure is wrong. The need to be taken from the original (the blue logo)
image

msfussell
msfussell previously approved these changes Jun 11, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell dismissed their stale review June 11, 2024 00:48

Found another update.

@msfussell
Copy link
Member

I realize that the order in the table here daprdocs/content/en/concepts/building-blocks-concept.md should also change. Are there any other places like this in the body of the topics?

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 28c9011 into dapr:v1.13 Jun 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOC: Rearrange APIs in order of popularity
2 participants