Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaced actors #4192

Merged
merged 19 commits into from
Jun 18, 2024
Merged

Namespaced actors #4192

merged 19 commits into from
Jun 18, 2024

Conversation

hhunter-ms
Copy link
Collaborator

Description

  • Added section for namespaced actors in Actors overview
  • Create new doc for namespaced actors detail
  • Update example in Placement service doc
  • Update example in Placement API doc
  • Diagrams
  • Reorder docs to make room for Namespaced Actors doc in Actors section of Developing Applications/Building Blocks TOC

Issue reference

PR will close: #4118

@hhunter-ms hhunter-ms self-assigned this Jun 11, 2024
@hhunter-ms hhunter-ms requested review from a team as code owners June 11, 2024 21:42
@hhunter-ms hhunter-ms changed the title Namespaced actors [WIP] Namespaced actors Jun 11, 2024
@hhunter-ms hhunter-ms added this to the 1.14 milestone Jun 11, 2024
@hhunter-ms
elena review
2d3b491 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
forgot to save
7356e7b 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
update json example in api doc
a9c8f93 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Copy link
Collaborator Author

@elena-kolevska I was thinking of putting an code example in namespaced-actors.md. should I just use what we have in placement.md and placement_api.md?

@hhunter-ms
remove examples section
0ab817d 
Signed-off-by: Hannah Hunter <[email protected]>
msfussell
msfussell reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments as discussed

daprdocs/content/en/concepts/dapr-services/placement.md Outdated Show resolved Hide resolved
daprdocs/content/en/concepts/dapr-services/placement.md Outdated Show resolved Hide resolved
daprdocs/content/en/concepts/dapr-services/placement.md Outdated Show resolved Hide resolved
daprdocs/content/en/concepts/dapr-services/placement.md Outdated Show resolved Hide resolved
daprdocs/content/en/concepts/dapr-services/placement.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/placement_api.md Show resolved Hide resolved
daprdocs/content/en/reference/api/placement_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/placement_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/placement_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/namespaced-actors.md Outdated Show resolved Hide resolved
@hhunter-ms hhunter-ms changed the title [WIP] Namespaced actors Namespaced actors Jun 17, 2024
@hhunter-ms
remove images
d8640e8 
Signed-off-by: Hannah Hunter <[email protected]>
msfussell
msfussell reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments and updates

daprdocs/content/en/concepts/terminology.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/namespaced-actors.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/namespaced-actors.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/namespaced-actors.md Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/namespaced-actors.md Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/namespaced-actors.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/namespaced-actors.md Outdated Show resolved Hide resolved
daprdocs/content/en/concepts/terminology.md Outdated Show resolved Hide resolved
hhunter-ms and others added 4 commits June 17, 2024 15:44
@hhunter-ms @msfussell
Update daprdocs/content/en/developing-applications/building-blocks/ac…
94a7d72 
…tors/namespaced-actors.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms @msfussell
Update daprdocs/content/en/developing-applications/building-blocks/ac…
537b18c 
…tors/namespaced-actors.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
updates from Mark
f28b7c9 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Merge branch 'issue_4118' of https://github.com/hhunter-ms/docs into …
c274edf 
…issue_4118
elena-kolevska
elena-kolevska requested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change (in two places).

daprdocs/content/en/developing-applications/building-blocks/actors/actors-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/namespaced-actors.md Outdated Show resolved Hide resolved
@hhunter-ms hhunter-ms mentioned this pull request Jun 18, 2024
Merged
msfussell
msfussell approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One update to make. LGTM

@hhunter-ms hhunter-ms merged commit bf979e9 into dapr:v1.14 Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elena-kolevska elena-kolevska elena-kolevska requested changes

@msfussell msfussell msfussell approved these changes

Assignees

@hhunter-ms hhunter-ms

Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@hhunter-ms @elena-kolevska @msfussell