Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update fields as they are optional #4371

Closed
wants to merge 1 commit into from

Conversation

sicoyle
Copy link
Contributor

@sicoyle sicoyle commented Oct 7, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Docs updates given these changes
https://github.com/dapr/components-contrib/pull/3562/files

Issue reference

@sicoyle sicoyle requested review from a team as code owners October 7, 2024 16:52
@@ -65,8 +65,8 @@ The AWS authentication token will be dynamically rotated before it's expiration
| `useAWSIAM` | Y | Must be set to `true` to enable the component to retrieve access tokens from AWS IAM. This authentication method only works with AWS Relational Database Service for PostgreSQL databases. | `"true"` |
| `connectionString` | Y | The connection string for the PostgreSQL database.<br>This must contain an already existing user, which corresponds to the name of the user created inside PostgreSQL that maps to the AWS IAM policy. This connection string should not contain any password. Note that the database name field is denoted by dbname with AWS. | `"host=mydb.postgres.database.aws.com user=myapplication port=5432 dbname=my_db sslmode=require"`|
| `awsRegion` | Y | The AWS Region where the AWS Relational Database Service is deployed to. | `"us-east-1"` |
| `awsAccessKey` | Y | AWS access key associated with an IAM account | `"AKIAIOSFODNN7EXAMPLE"` |
| `awsSecretKey` | Y | The secret key associated with the access key | `"wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"` |
| `awsAccessKey` | N | AWS access key associated with an IAM account | `"AKIAIOSFODNN7EXAMPLE"` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target the v1.15 branch

@sicoyle sicoyle changed the base branch from v1.14 to v1.15 October 9, 2024 12:20
@sicoyle sicoyle changed the base branch from v1.15 to v1.14 October 9, 2024 12:21
Copy link

Stale PR, paging all reviewers

Copy link

Stale PR, paging all reviewers

@hhunter-ms
Copy link
Collaborator

@sicoyle does this PR need to point to 1.15?

Copy link

Stale PR, paging all reviewers

@msfussell
Copy link
Member

@sicoyle - You will need to create a new PR for this

Copy link

github-actions bot commented Nov 6, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Nov 6, 2024
@github-actions github-actions bot closed this Nov 13, 2024
@hhunter-ms hhunter-ms reopened this Nov 19, 2024
@hhunter-ms hhunter-ms removed the stale label Nov 19, 2024
Copy link

Stale PR, paging all reviewers

Copy link

github-actions bot commented Dec 1, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 1, 2024
@hhunter-ms hhunter-ms removed the stale label Dec 2, 2024
@sicoyle
Copy link
Contributor Author

sicoyle commented Dec 3, 2024

closing as i am fixing in a diff pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants