-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exhaustive list of error codes and description of metric flag #4422
Open
jake-engelberg
wants to merge
6
commits into
dapr:v1.15
Choose a base branch
from
jake-engelberg:add-errorcode-metrics
base: v1.15
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+172
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jake Engelberg <[email protected]>
7 tasks
nelson-parente
approved these changes
Nov 8, 2024
daprdocs/content/en/operations/observability/metrics/metrics-overview.md
Outdated
Show resolved
Hide resolved
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Signed-off-by: Jake Engelberg <[email protected]>
hhunter-ms
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick review - thank you!
daprdocs/content/en/operations/observability/metrics/metrics-overview.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Jake Engelberg <[email protected]>
jake-engelberg
force-pushed
the
add-errorcode-metrics
branch
from
December 3, 2024 16:16
ab17803
to
a44a96a
Compare
hhunter-ms
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Added the exhaustive set of error codes dapr emits as well as how to enable metric recording for these error codes based on the associated PR below which implements this.
Issue reference
dapr/dapr#8256