-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating valid .NET SDK targets for Quickstart docs #4447
base: v1.15
Are you sure you want to change the base?
Conversation
…ed 1.16 deprecation warnings for .NET 6 and .NET 7 Signed-off-by: Whit Waldo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my review comments.
daprdocs/content/en/getting-started/quickstarts/configuration-quickstart.md
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/actors-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/bindings-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo - Did you see my comments here on making this into a set of bullet points with rewording? |
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
@msfussell Nope - missed them in the wall of notifications this morning, so thank you for pointing them out. Updates made throughout on the latest commits. |
<!-- IGNORE_LINKS --> | ||
- [Docker Desktop](https://www.docker.com/products/docker-desktop) | ||
<!-- END_IGNORE --> | ||
- [.NET 6](https://dotnet.microsoft.com/download), [.NET 8](https://dotnet.microsoft.com/download) or [.NET 9](https://dotnet.microsoft.com/download) installed | ||
|
||
{{% alert title="Note" color="primary" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WhitWaldo {{% alert ... %}}
shortcode typically doesn't render when put between {{% codetab %}}
shortcode... could you build the site locally and see if it renders for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops - you caught me. Didn't test this one out locally. I'll see what I can get working on this.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Updated documentation for .NET Quickstarts to reflect that .NET 6, .NET 8 and .NET 9 are valid SDK targets, but also added standard deprecation warning indicating that only .NET 8 and .NET 9 will be supported in v1.16.
Please do not merge until dapr/dotnet-sdk#1404 has been merged