Resolve buildGrpcManagedChannel orphaned channel & ensure connections mocked #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cassandra Coyle <[email protected]>
…1 is unavailable. Will continue retrying.' Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
cicoyle
changed the title
Signed-off-by: Cassandra Coyle <[email protected]>
cicoyle
force-pushed
the
fix-connection-not-mocked
branch
from
7a344bd to
e26d403
Compare
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
cicoyle
force-pushed
the
fix-connection-not-mocked
branch
from
6062023 to
401e357
Compare
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
artursouza
force-pushed
the
fix-connection-not-mocked
branch
from
50e7607 to
8be728c
Compare
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
cicoyle
force-pushed
the
fix-connection-not-mocked
branch
from
8a53fc5 to
6f03ee0
Compare
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
artursouza
force-pushed
the
fix-connection-not-mocked
branch
from
3d1b91a to
52a3667
Compare
3 tasks
Signed-off-by: Cassandra Coyle <[email protected]>
Closed
Signed-off-by: Cassandra Coyle <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1003 +/- ##
============================================
+ Coverage 77.35% 77.42% +0.06%
- Complexity 1538 1539 +1
============================================
Files 143 143
Lines 4642 4642
Branches 541 541
============================================
+ Hits 3591 3594 +3
+ Misses 776 771 -5
- Partials 275 277 +2 ☔ View full report in Codecov by Sentry. |
artursouza
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to figure out which connection is not mocked and is causing CI issues.
Resolve the orphaned channel due to the
buildGrpcManagedChanneltest cases.Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: