Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate SpringBoot Versions & Fix Release Pipeline #1239

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Mar 7, 2025

Error:  Rule failure while trying to close staging repository with ID "iodapr-1082".
Error:  
Error:  Nexus Staging Rules Failure Report
Error:  ==================================
Error:  
Error:  Repository "iodapr-1082" failures
Error:    Rule "sources-staging" failures
Error:      * Missing: no sources jar found in folder '/io/dapr/producer-app/0.14.0-rc-3'
Error:      * Missing: no sources jar found in folder '/io/dapr/dapr-sdk-examples/1.14.0-rc-3'
Error:      * Missing: no sources jar found in folder '/io/dapr/consumer-app/0.14.0-rc-3'
Error:    Rule "javadoc-staging" failures
Error:      * Missing: no javadoc jar found in folder '/io/dapr/producer-app/0.14.0-rc-3'
Error:      * Missing: no javadoc jar found in folder '/io/dapr/dapr-sdk-examples/1.14.0-rc-3'
Error:      * Missing: no javadoc jar found in folder '/io/dapr/consumer-app/0.14.0-rc-3'
Error:  
Error:  
Error:  Cleaning up local stage directory after a Rule failure during close of staging repositories: [iodapr-1082]
Error:   * Deleting context 59243a4bfe8d4.properties
Error:  Cleaning up remote stage repositories after a Rule failure during close of staging repositories: [iodapr-1082]
Error:   * Dropping failed staging repository with ID "iodapr-1082" (Rule failure during close of staging repositories: [iodapr-1082]).

  • Fix springboot version warning by adding the pluginManagement section to the spring-boot-examples parent POM:
Warning:  
Warning:  Some problems were encountered while building the effective model for io.dapr:producer-app:jar:0.14.0-rc-3
Warning:  'build.plugins.plugin.version' for org.springframework.boot:spring-boot-maven-plugin is missing. @ line 79, column 15
Warning:  
Warning:  Some problems were encountered while building the effective model for io.dapr:consumer-app:jar:0.14.0-rc-3
Warning:  'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: io.dapr.spring:dapr-spring-boot-starter:jar -> version ${dapr-java-sdk.alpha-version} vs ${dapr.sdk.alpha.version} @ line 46, column 17
Warning:  'build.plugins.plugin.version' for org.springframework.boot:spring-boot-maven-plugin is missing. @ line 92, column 15
Warning:  
Warning:  It is highly recommended to fix these problems because they threaten the stability of your build.
Warning:  
Warning:  For this reason, future Maven versions might no longer support building such malformed projects.
Warning:  

cicoyle added 2 commits March 6, 2025 16:20
@cicoyle cicoyle requested review from a team as code owners March 7, 2025 04:04
<configuration>
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cicoyle what about this one? the Maven Site Plugin It think it generates a site for the project. We might need to skip this for both.

@salaboy
Copy link
Contributor

salaboy commented Mar 7, 2025

@cicoyle This looks good to me.. let's try against maven central.. that is the only way to check

@cicoyle cicoyle merged commit ff917ac into dapr:master Mar 7, 2025
8 checks passed
salaboy pushed a commit to salaboy/java-sdk that referenced this pull request Mar 10, 2025
* fix release

Signed-off-by: Cassandra Coyle <[email protected]>

* remove springboot v3.2.6 and use dapr-sdk-parent version

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants