Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geotagging.c: view entire track by clicking on list of track segments or use the shortcut #18016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

esq4
Copy link
Contributor

@esq4 esq4 commented Dec 15, 2024

To continue the conversation #17907.
I made three ways:
double-clicking LMB on the list of track segments
clicking LMB on the list header
shortcut option

@TurboGit TurboGit added this to the 5.2 milestone Dec 15, 2024
@TurboGit TurboGit added feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't labels Dec 15, 2024
@TurboGit
Copy link
Member

@esq4 : I rarely use the geotagging support, can you help me test this by providing a step-by-step procedure? TIA.

@esq4
Copy link
Contributor Author

esq4 commented Jan 25, 2025

@TurboGit : In the map view I open the desired gpx file and mark the segments in the list and Darktable shows the whole track in the center of the map. When I select a shot in the filmstrip, it is displayed on the track, and I zoom in on the map to see better where I took it. When I select another shot, it is displayed on the invisible part of the track. And here for a quick view of the whole track (to find this shot) I made three options: double-click LMB on the list of track segments,
LMB click on the list header on the invisible button (overlapping the header except for the checkbox) and the option of a keyboard shortcut that can be assigned to this invisible button. (I use the first two options.)

(I hope that I understood your request correctly.)

@TurboGit
Copy link
Member

TurboGit commented Feb 9, 2025

Ok, that's probably the missing piece of information. The button is invisible overlay, so:

  GtkWidget *gpx_view_button = dt_action_button_new(self, N_("view entire track"), _refresh_display_all_tracks, self,
                                        _("refresh map to view entire selected track segments"), 0, 0);

The label & tooltip here cannot be displayed on GUI, right?

If that's the case maybe add a comment on the code to ease future maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants