Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch exception in wamp_session::send_msg in case of problems with underlying socket #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uquendo
Copy link

@uquendo uquendo commented May 23, 2024

Catching write exception on the session it belongs to instead of propagating further (for example, to pubsub_man::update_topic) and possibly dropping the session that posted the data to the topic our problematic client is subscribed to.

Problem was observed when one slow subscriber (able to hit wampcc::default_socket_max_pending_write_bytes limit) was able to drop the sessions of all the publishers to the topics it is subscribed to.

@darrenjs
Copy link
Owner

Hi, I need to review this in a bit more in depth, because the call to handle_exception(); is really only intended for inbound traffic. Although the send_msg is also used internally. I will try to reproduce your error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants