This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Make AugmentResponse more like MacroExecutionResult #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding builder types, and making AugmentResponse not visible in the macro APIs any more. Will do that after #104 is also merged, as we really need both.
jakemac53
force-pushed
the
macro-execution-result
branch
from
3ffffc5 to
e5c685e
Compare
davidmorgan
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks!
Please see my comment on #104 for some general thoughts also relevant here, but this can be merged as is.
One possible way to proceed afterwards would be to have the methods return void, instead of returning a value, augmentations are accumulated in the Scope. (Dependency injection scope, not a Dart scope). This avoids mentioning AugmentationResult and seems like it should work well with builders.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding builder types, and making
AugmentResponsenot visible in the macro APIs any more.Will do that after #104 is also merged, as we really need both.