-
Notifications
You must be signed in to change notification settings - Fork 7
Add builder classes, make them the only parameter to macro methods #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
@davidmorgan I made some substantive changes to fix some of the tests that you should look at - lazy merged maps are now considered equal if their left/right maps are equal, and |
To fix the remaining tests I had to change the expectations, the I am not sure if this is a bad thing or a good thing... but these nodes shouldn't be re-used anyways. |
Thanks! Still LGTM. Re: lists and cycles, both seem fine for now. |
This is still a WIP, but I wanted to get it out there for an initial review.
query
API, which needs to be evaluated and hopefully restricted per phase in some way.