feat: cleanup metrics configs

dart-code-checker · Oct 4, 2021 · 5574a46 · 5574a46
1 parent 179c505
commit 5574a46
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 22 deletions.
diff --git a/lib/src/analyzers/lint_analyzer/metrics/metrics_factory.dart b/lib/src/analyzers/lint_analyzer/metrics/metrics_factory.dart
@@ -33,10 +33,14 @@ final _implementedMetrics = <String, Metric Function(Map<String, Object>)>{
 
 Iterable<Metric> getMetrics({
   required Map<String, Object> config,
+  Iterable<String> patternsDependencies = const [],
   EntityType? measuredType,
 }) {
-  final _metrics =
-      _implementedMetrics.keys.map((id) => _implementedMetrics[id]!(config));
+  final _metrics = _implementedMetrics.keys.map(
+    (id) => _implementedMetrics[id]!(
+      !patternsDependencies.contains(id) ? config : {},
+    ),
+  );
 
   return measuredType != null
       ? _metrics

diff --git a/lib/src/config_builder/config_builder.dart b/lib/src/config_builder/config_builder.dart
@@ -25,26 +25,35 @@ class ConfigBuilder {
     String excludesRootFolder, {
     Iterable<Metric<num>>? classMetrics,
     Iterable<Metric<num>>? functionMetrics,
-  }) =>
-      LintAnalysisConfig(
-        prepareExcludes(config.excludePatterns, excludesRootFolder),
-        getRulesById(config.rules),
-        prepareExcludes(config.excludeForRulesPatterns, excludesRootFolder),
-        getPatternsById(config),
-        classMetrics ??
-            getMetrics(
-              config: config.metrics,
-              measuredType: EntityType.classEntity,
-            ),
-        functionMetrics ??
-            getMetrics(
-              config: config.metrics,
-              measuredType: EntityType.methodEntity,
-            ),
-        prepareExcludes(config.excludeForMetricsPatterns, excludesRootFolder),
-        config.metrics,
-        excludesRootFolder,
-      );
+  }) {
+    final patterns = getPatternsById(config);
+    final patternsDependencies = patterns
+        .map((pattern) => pattern.dependentMetricIds)
+        .expand((e) => e)
+        .toSet();
+
+    return LintAnalysisConfig(
+      prepareExcludes(config.excludePatterns, excludesRootFolder),
+      getRulesById(config.rules),
+      prepareExcludes(config.excludeForRulesPatterns, excludesRootFolder),
+      patterns,
+      classMetrics ??
+          getMetrics(
+            config: config.metrics,
+            patternsDependencies: patternsDependencies,
+            measuredType: EntityType.classEntity,
+          ),
+      functionMetrics ??
+          getMetrics(
+            config: config.metrics,
+            patternsDependencies: patternsDependencies,
+            measuredType: EntityType.methodEntity,
+          ),
+      prepareExcludes(config.excludeForMetricsPatterns, excludesRootFolder),
+      config.metrics,
+      excludesRootFolder,
+    );
+  }
 
   static UnusedFilesConfig getUnusedFilesConfigFromArgs(
     Iterable<String> excludePatterns,