fix: correctly available check rule names (#1068)

dart-code-checker · Nov 2, 2022 · 8bc1a3c · 8bc1a3c
1 parent b8285c7
commit 8bc1a3c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+* fix: correctly available check rule names.
+
 ## 5.0.0
 
 * feat: **Breaking change** rename `member-ordering-extended` to `member-ordering`, discarding the old implementation.

diff --git a/lib/src/analyzers/lint_analyzer/lint_analysis_options_validator.dart b/lib/src/analyzers/lint_analyzer/lint_analysis_options_validator.dart
@@ -9,6 +9,7 @@ import 'lint_analysis_config.dart';
 import 'models/issue.dart';
 import 'models/lint_file_report.dart';
 import 'models/severity.dart';
+import 'rules/rules_factory.dart';
 
 class LintAnalysisOptionsValidator {
   static LintFileReport? validateOptions(
@@ -28,11 +29,11 @@ class LintAnalysisOptionsValidator {
       return null;
     }
 
-    final parsedRuleIds = config.codeRules.map((rule) => rule.id).toList();
+    final ids = allRuleIds.toSet();
     final issues = <Issue>[];
 
     for (final rule in rulesList) {
-      if (!parsedRuleIds.contains(rule.ruleName)) {
+      if (!ids.contains(rule.ruleName)) {
         issues.add(
           Issue(
             ruleId: 'unknown-config',

diff --git a/lib/src/analyzers/lint_analyzer/rules/rules_factory.dart b/lib/src/analyzers/lint_analyzer/rules/rules_factory.dart
@@ -144,6 +144,8 @@ final _implementedRules = <String, Rule Function(Map<String, Object>)>{
   TagNameRule.ruleId: TagNameRule.new,
 };
 
+Iterable<String> get allRuleIds => _implementedRules.keys;
+
 Iterable<Rule> get allRules =>
     _implementedRules.keys.map((id) => _implementedRules[id]!({}));