Expose object metadata from Bucket.list
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Nov 1, 2024
| @@ -1,5 +1,16 @@ | |||
| ## 0.8.16-wip | |||
There was a problem hiding this comment.
Should we mark this with a breaking version change?
We are still not 1.0.0 so I think we shouldn't worry too much
There was a problem hiding this comment.
I don't know, it's not likely to break anyone.
sigurdm
approved these changes
Nov 1, 2024
sigurdm
reviewed
Nov 1, 2024
github-actions
bot
added
the
type-infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly breaking change, mostly for people who are subclassing
BucketEntry.Which someone might do if they are mocking or faking objects for testing.
But for almost everyone else this is a non-breaking change.
We could avoid adding
sealed, but then switch'ing onBucketEntrywouldn't be exhaustive.