Add LazyMergedMap for merging Model objects #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
changed the title
davidmorgan
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks!
Yes, I think we almost certainly want this, the only way I could see avoiding it is if we require that macros only make one query.
There is a TODO for merging the model into the current scope here
macros/pkgs/dart_model/lib/src/scopes.dart
Line 162 in a482288
which could directly use this, not sure if that's useful to do in this PR or not.
Oh nice, I will add that |
jakemac53
force-pushed
the
lazy-merged-map
branch
from
d22e3f4
to
0e1d468
Compare
davidmorgan
reviewed
Oct 22, 2024
| _accumulatedModel = model; | ||
| _typeSystem = null; | ||
| if (_accumulatedModel case var accumulated?) { | ||
| accumulated.mergeWith(model); |
There was a problem hiding this comment.
I think that should be _accumulatedModel = ... :)
I guess we don't have any test coverage for this :) meaning we never use the type system after a second query.
jakemac53
added a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly resolution to #102, not high priority to land right away just putting something out there.
Has a few failing tests right now which I can look at if we want to move forward.
We might want to benchmark this also if we decide to land it.