Add built_value test macro. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
approved these changes
Nov 20, 2024
| } | ||
|
|
||
| String _removePrefix(String name) { | ||
| final index = name.indexOf('.'); |
There was a problem hiding this comment.
Can you add a comment to this function describing exactly what prefix it is removing? I am confused.
There was a problem hiding this comment.
Done.
It's import prefixes, so @prefix0.BuiltValueBuilder() in the macro output was resulting in name prefix0.BuiltValueBuilder here. The prefix is meaningless since we have the URI and what we care about is the name in that URI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured we can use a macro that fully uses phase 1+2 for benchmarking, some approximation to
built_valueseems a good fit.I found a few fixes needed before I got to adding fields, so I figured I'd send already.