Use package:_macro_host in _cfe_macros. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW there is clearly a temptation here to dedupe code between the two :) I'm not sure yet how much duplication there will be, most of it will be the query handling, a lot of which will be different for analyzer and CFE. Even with that, I guess there's a good chance we end up with a common package sharing code between the two. Probably a few PRs down the line is the time to add such a thing :) |
|
Upstream landed, so updated to use that ref in the pubspec making this now landable :) |
jakemac53
approved these changes
Aug 8, 2024
| import 'package:macros/src/executor.dart' as injected; | ||
|
|
||
| /// Injected macro implementation for the analyzer. | ||
| class MacroImplementation implements injected.MacroImplementation { |
There was a problem hiding this comment.
nit: I would rename this one also (CfeMacroImplementation), and rename the analyzer one also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs an upstream fix as the code I added in the CFE is passing the wrong macro name, will send it today.
The rest is mostly the same as the analyzer version, except: 1) the CFE is passing a mix of absolute URIs and package URIs, currently I just work around that in the test; and 2) the CFE breaks if empty augmentations are returned, I worked around that too with a TODO.