-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_assets_builder] Report dart sources as dependencies of hooks #1780
Open
dcharkes
wants to merge
1
commit into
main
Choose a base branch
from
dependencies-dart-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+118
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package:native_assets_builder
type-infra
A repository infrastructure change or enhancement
labels
Dec 3, 2024
dcharkes
force-pushed
the
dependencies-dart-files
branch
from
December 4, 2024 10:21
51dd61c
to
fde2f0a
Compare
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
dcharkes
force-pushed
the
dependencies-dart-files
branch
from
December 4, 2024 12:12
fde2f0a
to
90eee5b
Compare
dcharkes
force-pushed
the
dependencies-dart-files
branch
from
December 4, 2024 12:18
90eee5b
to
36da1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1770
This PR adds the Dart sources to the dependencies in
HookResult
.It also fixes the dep-file parsing w.r.t. to escapes.
Implementation details
We're passing around
HookOutput
s which is the deserializedoutput.json
. We could add the Dart sources as dependencies to it after deserializing, but then the correspondence to the json is lost. So instead I've added an extra return value to the places where we passHookOutput
around.