Have the analyze portion of publishing validation only analyze bin/ a…

…nd lib/ (#4068)

analysis_options.yaml

@@ -23,7 +23,6 @@ linter:
     - avoid_unused_constructor_parameters
     - avoid_void_async
     - cancel_subscriptions
-    - dangling_library_doc_comments
     - directives_ordering
     - library_annotations
     - missing_whitespace_between_adjacent_strings
@@ -44,8 +43,6 @@ linter:
     - unawaited_futures
     - unnecessary_lambdas
     - unnecessary_library_directive
-    - unnecessary_null_aware_assignments
     - unnecessary_parenthesis
     - unnecessary_statements
     - use_enums
-    - use_super_parameters

lib/src/validator/analyze.dart

@@ -14,15 +14,17 @@ import '../validator.dart';
 
 /// Runs `dart analyze` and gives a warning if it returns non-zero.
 class AnalyzeValidator extends Validator {
-  /// Only analyze dart code in the following sub-folders.
+  // Only analyze dart code in the following sub-folders.
+  static const List<String> _dirsToAnalyze = ['lib', 'bin'];
+
   @override
   Future<void> validate() async {
-    final dirsToAnalyze = ['lib', 'test', 'bin']
+    final dirs = _dirsToAnalyze
         .map((dir) => p.join(entrypoint.rootDir, dir))
         .where(dirExists);
     final result = await runProcess(
       Platform.resolvedExecutable,
-      ['analyze', ...dirsToAnalyze, p.join(entrypoint.rootDir, 'pubspec.yaml')],
+      ['analyze', ...dirs, p.join(entrypoint.rootDir, 'pubspec.yaml')],
     );
     if (result.exitCode != 0) {
       final limitedOutput = limitLength(result.stdout.join('\n'), 1000);

lib/src/validator/compiled_dartdoc.dart

@@ -9,8 +9,7 @@ import 'package:path/path.dart' as path;
 import '../io.dart';
 import '../validator.dart';
 
-/// Validates that a package doesn't contain compiled Dartdoc
-/// output.
+/// Validates that a package doesn't contain compiled Dartdoc output.
 class CompiledDartdocValidator extends Validator {
   @override
   Future validate() {

test/validator/analyze_test.dart

@@ -141,32 +141,4 @@ void main() {
       workingDirectory: d.sandbox,
     );
   });
-
-  test('should warn if package contains warnings in test folder', () async {
-    await d.dir(appPath, [
-      d.validPubspec(),
-      d.file('LICENSE', 'Eh, do what you want.'),
-      d.file('README.md', "This package isn't real."),
-      d.file('CHANGELOG.md', '# 1.0.0\nFirst version\n'),
-      d.dir('lib', [d.file('test_pkg.dart', 'int i = 1;')]),
-      d.dir('test', [
-        d.file('test_pkg.dart', '''
-void main() {
-  final a = 10; // Unused.
-}
-'''),
-      ]),
-    ]).create();
-
-    await expectValidation(
-      error: allOf([
-        contains('`dart analyze` found the following issue(s):'),
-        contains('Analyzing lib, test, pubspec.yaml...'),
-        contains('warning -'),
-        contains("The value of the local variable 'a' isn't used"),
-        contains('Package has 1 warning.'),
-      ]),
-      exitCode: DATA,
-    );
-  });
 }