Skip to content

Commit

Permalink
[dart2js_runtime_metrics] Update pubspec to 3.7 and reformat.
Browse files Browse the repository at this point in the history
Change-Id: Ia1e81df8120f02d5d26297a84ef1e5e8f110d040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400740
Reviewed-by: Nate Biggs <[email protected]>
Auto-Submit: Mayank Patke <[email protected]>
Commit-Queue: Nate Biggs <[email protected]>
  • Loading branch information
fishythefish authored and Commit Queue committed Dec 13, 2024
1 parent 0d12749 commit 3606781
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
4 changes: 1 addition & 3 deletions pkg/dart2js_runtime_metrics/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ description: >-
This library provides access to the measurements at runtime.
environment:
# Restrict the upper bound so that we can remove support for this in
# a later version of the SDK without it being a breaking change.
sdk: ">=2.14.0 <2.15.0"
sdk: "^3.7.0-0"

# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
Expand Down
7 changes: 5 additions & 2 deletions pkg/dart2js_runtime_metrics/test/runtime_metrics_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ void main() {
}

Expect.isTrue(metrics.containsKey('runtime'), "Has 'runtime' key: $metrics");
Expect.equals(expectedRuntime, metrics['runtime'],
"Expected 'runtime: $expectedRuntime': $metrics");
Expect.equals(
expectedRuntime,
metrics['runtime'],
"Expected 'runtime: $expectedRuntime': $metrics",
);

if (expectedRuntime == 'dart2js') {
Expect.isTrue(metrics.containsKey('allocations'));
Expand Down
7 changes: 5 additions & 2 deletions pkg/dart2js_runtime_metrics/test/startup_metrics_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ void main() {
}

Expect.isTrue(metrics.containsKey('runtime'), "Has 'runtime' key: $metrics");
Expect.equals(expectedRuntime, metrics['runtime'],
"Expected 'runtime: $expectedRuntime': $metrics");
Expect.equals(
expectedRuntime,
metrics['runtime'],
"Expected 'runtime: $expectedRuntime': $metrics",
);

if (expectedRuntime == 'dart2js') {
Expect.isTrue(metrics.containsKey('callMainMs'));
Expand Down

0 comments on commit 3606781

Please sign in to comment.