[dds/dap] Set supportsANSIStyling=true in DAP server capabilities

This is the proper fix for Dart-Code/Dart-Code#5302, which is to advertise to clients that we may use ansi color codes in output events. It requires increasing the DAP constraint because this field was added to the DAP package in 1.4.0 and we need to ensure anyone (like Flutter) building on top of this base debug adapter has a matching version. Change-Id: Ie595cda91389f1c7f031a657c96e9f7480b00933 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397521 Reviewed-by: Derek Xu <[email protected]> Commit-Queue: Ben Konyi <[email protected]> Reviewed-by: Ben Konyi <[email protected]>
dart-lang · Nov 26, 2024 · a990da0 · a990da0
1 parent a999cec
commit a990da0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/pkg/dds/CHANGELOG.md b/pkg/dds/CHANGELOG.md
@@ -8,6 +8,8 @@
   collected while execution is paused, while releasing them once execution
   resumes.
 - Updated `vm_service` constraint to ^14.3.0.
+- [DAP] Updated `dap` constraint to ^1.4.0.
+- [DAP] Set `supportsANSIStyling` to `true` in debug adapter capabilities to indicate that `Output` events might contain ansi color codes.
 
 # 4.2.7
 - Added a new constant `RpcErrorCodes.kConnectionDisposed = -32010` for requests

diff --git a/pkg/dds/lib/src/dap/adapters/dart.dart b/pkg/dds/lib/src/dap/adapters/dart.dart
@@ -1249,6 +1249,7 @@ abstract class DartDebugAdapter<TL extends LaunchRequestArguments,
           defaultValue: true,
         ),
       ],
+      supportsANSIStyling: true,
       supportsClipboardContext: true,
       supportsConditionalBreakpoints: true,
       supportsConfigurationDoneRequest: true,

diff --git a/pkg/dds/pubspec.yaml b/pkg/dds/pubspec.yaml
@@ -14,7 +14,7 @@ dependencies:
   browser_launcher: ^1.0.0
   collection: ^1.15.0
   dds_service_extensions: ^2.0.0
-  dap: ^1.3.0
+  dap: ^1.4.0
   extension_discovery: ^2.0.0
   devtools_shared: ^11.0.0
   http_multi_server: ^3.0.0