Skip to content

Commit

Permalink
Elements. Migrate verifySuperFormalParameters()
Browse files Browse the repository at this point in the history
Change-Id: I1ce336a406a8bcb1fcc1446b03c0f7c9473cb00a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395045
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
  • Loading branch information
scheglov authored and Commit Queue committed Nov 13, 2024
1 parent ce36fba commit aa3eb29
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
1 change: 0 additions & 1 deletion pkg/analyzer/analyzer_use_new_elements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ lib/src/error/must_call_super_verifier.dart
lib/src/error/nullable_dereference_verifier.dart
lib/src/error/override_verifier.dart
lib/src/error/required_parameters_verifier.dart
lib/src/error/super_formal_parameters_verifier.dart
lib/src/error/type_arguments_verifier.dart
lib/src/error/unused_local_elements_verifier.dart
lib/src/error/use_result_verifier.dart
Expand Down
13 changes: 7 additions & 6 deletions pkg/analyzer/lib/src/error/super_formal_parameters_verifier.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/error/listener.dart';
import 'package:analyzer/src/dart/ast/ast.dart';
import 'package:analyzer/src/dart/ast/extensions.dart';
import 'package:analyzer/src/dart/element/element.dart';
import 'package:analyzer/src/error/codes.dart';

VerifySuperFormalParametersResult verifySuperFormalParameters({
Expand All @@ -16,11 +15,13 @@ VerifySuperFormalParametersResult verifySuperFormalParameters({
var result = VerifySuperFormalParametersResult();
for (var parameter in constructor.parameters.parameters) {
parameter = parameter.notDefault;
if (parameter is SuperFormalParameter) {
var parameterElement =
parameter.declaredElement as SuperFormalParameterElementImpl;
if (parameter is SuperFormalParameterImpl) {
var declaredFragment = parameter.declaredFragment!;
if (parameter.isNamed) {
result.namedArgumentNames.add(parameterElement.name);
var name = declaredFragment.name2;
if (name != null) {
result.namedArgumentNames.add(name);
}
} else {
result.positionalArgumentCount++;
if (hasExplicitPositionalArguments) {
Expand Down

0 comments on commit aa3eb29

Please sign in to comment.