Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sdk archives table to Jaspr #6312

Merged
merged 11 commits into from
Feb 25, 2025
Merged

Conversation

schultek
Copy link
Contributor

@schultek schultek commented Jan 7, 2025

This migrates the sdk archives table shown in https://dart.dev/get-dart/archive to Jaspr, as discussed with @parlough.

There is no visual or functional change to the table from the end-user perspective. Though I made some very light cosmetic changes:

  • The <form> and <table> elements are now wrapped in an additional <div> to act as the attach target for Jaspr.
  • The template row changed from '0.0.0-0.0.dev (rev 00000) | Windows | 64-width | 01/01/1970 | JSON-formatted API documentation' to '0.0.0 (ref 00000) | --- | --- | 01/01/1970 | '.

I also added some new tests for the component using Jasprs testing library.

@parlough parlough self-assigned this Jan 7, 2025
@schultek
Copy link
Contributor Author

schultek commented Feb 4, 2025

@parlough Anything I can do to move this along?

@parlough
Copy link
Member

@parlough Anything I can do to move this along?

Sorry for the delay here @schultek, thanks again for working on this migration! I'm hoping to take a look in the next few days. If you have a chance, could you resolve the merge conflicts and update to jaspr 0.17? Otherwise, I'd be happy to make those updates before I review.

schultek and others added 5 commits February 20, 2025 09:15
# Conflicts:
#	src/content/assets/js/get-dart/download_archive.dart.js
#	tool/get-dart/dart_sdk_archive/lib/src/operating_system.dart
#	tool/get-dart/dart_sdk_archive/lib/src/version_selector.dart
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Feb 24, 2025

Visit the preview URL for this PR (updated for commit 673791f):

https://dart-dev--pr6312-jaspr-archive-5iems55x.web.app

@parlough
Copy link
Member

/gcbrun

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super amazing @schultek! Thanks for experimenting with this and getting it in a state to land, even adding tests 💙

@parlough parlough merged commit 7e3e939 into dart-lang:main Feb 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants