-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate sdk archives table to Jaspr #6312
Conversation
@parlough Anything I can do to move this along? |
Sorry for the delay here @schultek, thanks again for working on this migration! I'm hoping to take a look in the next few days. If you have a chance, could you resolve the merge conflicts and update to jaspr 0.17? Otherwise, I'd be happy to make those updates before I review. |
# Conflicts: # src/content/assets/js/get-dart/download_archive.dart.js # tool/get-dart/dart_sdk_archive/lib/src/operating_system.dart # tool/get-dart/dart_sdk_archive/lib/src/version_selector.dart
Visit the preview URL for this PR (updated for commit 673791f): |
d19869c
to
da652cc
Compare
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super amazing @schultek! Thanks for experimenting with this and getting it in a state to land, even adding tests 💙
This migrates the sdk archives table shown in https://dart.dev/get-dart/archive to Jaspr, as discussed with @parlough.
There is no visual or functional change to the table from the end-user perspective. Though I made some very light cosmetic changes:
<form>
and<table>
elements are now wrapped in an additional<div>
to act as the attach target for Jaspr.I also added some new tests for the component using Jasprs testing library.