Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text regarding including shared analysis options #6402

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Feb 10, 2025

Fixes #6174.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@srawlins
Copy link
Member Author

CC @parlough @bwilkerson I'd love love love feedback, thanks!

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Feb 10, 2025

Visit the preview URL for this PR (updated for commit 3ba8930):

https://dart-dev--pr6402-multiple-shares-1ytpqi9p.web.app

Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of comments, but they're all just opinions, so do with them as you please.

src/content/tools/analysis.md Outdated Show resolved Hide resolved
src/content/tools/analysis.md Outdated Show resolved Hide resolved
src/content/tools/analysis.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srawlins! Some edits for clarity

src/content/tools/analysis.md Outdated Show resolved Hide resolved
src/content/tools/analysis.md Outdated Show resolved Hide resolved
src/content/tools/analysis.md Outdated Show resolved Hide resolved
src/content/tools/analysis.md Outdated Show resolved Hide resolved
src/content/tools/analysis.md Outdated Show resolved Hide resolved
src/content/tools/analysis.md Outdated Show resolved Hide resolved
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me once Marya's suggestions are applied.

Thanks so much for tackling the feature and these docs :D

@MaryaBelanger
Copy link
Contributor

Thanks @srawlins! Some edits for clarity

Since these are all just grammar / wording, I'm going to commit them and merge the PR :) Thanks again Sam!

@srawlins
Copy link
Member Author

Thanks a million, Marya!

@MaryaBelanger MaryaBelanger merged commit e32e97b into dart-lang:main Feb 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that multiple files can be included in analysis options, in analyzer 3.7 maybe
5 participants