-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text regarding including shared analysis options #6402
Conversation
CC @parlough @bwilkerson I'd love love love feedback, thanks! |
Visit the preview URL for this PR (updated for commit 3ba8930): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of comments, but they're all just opinions, so do with them as you please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @srawlins! Some edits for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me once Marya's suggestions are applied.
Thanks so much for tackling the feature and these docs :D
Since these are all just grammar / wording, I'm going to commit them and merge the PR :) Thanks again Sam! |
Thanks a million, Marya! |
Fixes #6174.
Contribution guidelines:
dart format
.<?code-excerpt
need to be updated in their source.dart
file as well.