Encode visual/collision name attribute in ShapeNode name

dartsim · Aug 22, 2021 · fc2d5e4 · fc2d5e4
1 parent 0dafab2
commit fc2d5e4
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/dart/utils/sdf/SdfParser.cpp b/dart/utils/sdf/SdfParser.cpp
@@ -1028,10 +1028,12 @@ void readVisualizationShapeNode(
     const common::Uri& baseUri,
     const common::ResourceRetrieverPtr& retriever)
 {
+  assert(hasAttribute(vizShapeNodeEle, "name"));
+  const std::string visualName = getAttributeString(vizShapeNodeEle, "name");
   dynamics::ShapeNode* newShapeNode = readShapeNode(
       bodyNode,
       vizShapeNodeEle,
-      bodyNode->getName() + " - visual shape",
+      bodyNode->getName() + " - " + visualName,
       baseUri,
       retriever);
 
@@ -1052,10 +1054,12 @@ void readCollisionShapeNode(
     const common::Uri& baseUri,
     const common::ResourceRetrieverPtr& retriever)
 {
+  assert(hasAttribute(collShapeNodeEle, "name"));
+  const std::string collName = getAttributeString(collShapeNodeEle, "name");
   dynamics::ShapeNode* newShapeNode = readShapeNode(
       bodyNode,
       collShapeNodeEle,
-      bodyNode->getName() + " - collision shape",
+      bodyNode->getName() + " - " + collName,
       baseUri,
       retriever);