Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix servo motor doesn't respect joint position limits #1587

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fix servo motor doesn't respect joint position limits #1587

merged 1 commit into from
Jul 7, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 7, 2021 •
edited
Loading

Fixes #1583

Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.11.0 milestone Jul 7, 2021
@jslee02 jslee02 mentioned this pull request Jul 7, 2021
Closed
2 tasks
@jslee02 jslee02 force-pushed the bugfix/servo_motor_with_pos_limits branch from c5e4de0 to 9e11437 Compare July 7, 2021 16:11
@jslee02 jslee02 marked this pull request as ready for review July 7, 2021 16:11
@jslee02 jslee02 merged commit 5058255 into release-6.11 Jul 7, 2021
@jslee02 jslee02 deleted the bugfix/servo_motor_with_pos_limits branch July 7, 2021 23:05
@scpeters scpeters mentioned this pull request Aug 22, 2021
Closed
2 tasks
@scpeters
Copy link
Collaborator

I believe that the simulation now crashes when universal joints reach their position limits due to this change; see #1596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jslee02 @scpeters