Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up #60

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Clean up #60

merged 8 commits into from
Nov 6, 2023

Conversation

darwin67
Copy link
Owner

@darwin67 darwin67 commented Nov 5, 2023

remove some unused files and move router and dev server (for tests) under supervision tree

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #60 (f95b4be) into main (05d6b51) will decrease coverage by 2.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   17.64%   15.15%   -2.50%     
==========================================
  Files          18       16       -2     
  Lines         272      264       -8     
==========================================
- Hits           48       40       -8     
  Misses        224      224              
Files Coverage Δ
lib/inngest/function/op.ex 0.00% <ø> (ø)
lib/inngest/router/invoke.ex 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@darwin67 darwin67 marked this pull request as ready for review November 6, 2023 07:58
@darwin67 darwin67 merged commit d3c5938 into main Nov 6, 2023
5 of 6 checks passed
@darwin67 darwin67 deleted the cleanup branch November 6, 2023 07:58
darwin67 added a commit that referenced this pull request Nov 7, 2023
* remove enum file and previous handler
* remove unused code and comment
* update comments
* move test cases into test directory
* Move dev plug router under supervision tree
* load inngest dev server as supervised genserver

---------

Co-authored-by: Darwin D Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant